Adds microceph client configuration support for rbd_cache #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UtkarshBhatthere
changed the title
UtkarshBhatthere
force-pushed
the
feature/clientConfig
branch
2 times, most recently
from
b759112 to
b1a0401
Compare
UtkarshBhatthere
force-pushed
the
feature/clientConfig
branch
7 times, most recently
from
72ecd35 to
291c10d
Compare
UtkarshBhatthere
force-pushed
the
feature/clientConfig
branch
5 times, most recently
from
b1c809e to
d522be5
Compare
sabaini
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Hi @UtkarshBhatthere thanks for the PR, I've done a quick scan (not finished yet).
I've left some nits inline. Please consider adding doc comments to the public functions/methods, and possibly for the API funcs as well even if non-public
lmlg
requested changes
Oct 16, 2023
UtkarshBhatthere
force-pushed
the
feature/clientConfig
branch
4 times, most recently
from
70465b0 to
09b6f46
Compare
sabaini
requested changes
Oct 17, 2023
There was a problem hiding this comment.
Heya @UtkarshBhatthere many thanks for this!
I've finally managed to go through the PR and added some inline commentary
UtkarshBhatthere
force-pushed
the
feature/clientConfig
branch
6 times, most recently
from
96cd730 to
2ee0c3f
Compare
UtkarshBhatthere
force-pushed
the
feature/clientConfig
branch
from
2ee0c3f to
15789ef
Compare
sabaini
requested changes
Oct 23, 2023
Signed-off-by: Utkarsh Bhatt <[email protected]>
Signed-off-by: Utkarsh Bhatt <[email protected]>
Signed-off-by: Utkarsh Bhatt <[email protected]>
Signed-off-by: Utkarsh Bhatt <[email protected]>
Signed-off-by: Utkarsh Bhatt <[email protected]>
UtkarshBhatthere
force-pushed
the
feature/clientConfig
branch
from
15789ef to
ac707dd
Compare
sabaini
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.